resize.cpp: fix memory leak #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveMacenski
approved these changes
Dec 28, 2019
mikeferguson
pushed a commit
that referenced
this pull request
Jan 19, 2024
Related with this PR in ROS 1 #489 Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Jan 19, 2024
Related with this PR in ROS 1 #489 Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Jan 19, 2024
Related with this PR in ROS 1 #489 Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instantiating
cv::Matwithout passing custom data storage in callback function causes memory leak on the end of callback function.This PR fixes the issue by using
toCvSharemethod to re-use data storage ofimage_msgfor an original image and a class member variablescaled_cv_which holdscv::Matas a member for a scaled image instead of implicitly initializingcv::Mat.