-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update depth_image_proc components #543
update depth_image_proc components #543
Conversation
This makes them loadable with the rclcpp_components interface. I've fully tested PointCloudXYZRGB and ConvertMetric, my use case doesn't use the others. I also lack a setup to test the launch files fully, but ran them with the realsense commented out and they appear to be OK.
CI seems to have failed in image_view -- which I'm not changing... |
@mikeferguson yeah, you can ignore the image_view failures in the PR builder, but Circle should pass without an issue
Looks like you need to lint a few lines. I get daily failure emails reminding me about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when CircleCi passes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you're missing the CMake changes necessary to support registration as composable nodes. First, the nodes have to be part of a shared library target (not an executable target). Then, you need to register them with an rclcpp_components
macro:
rclcpp_components_register_nodes(library_target_name Plugin::Class::Name)
@SteveMacenski - I'll get the python fixed up later today. @JWhitleyWork - it's already a library and the rclcpp_components_register_nodes directives were already there. Basically, without my changes, ComponentManager could already find the library and load it, but was unable to find the plugins since they had the wrong ClassLoader directive and constructor signature (I'm guessing they were ported at an earlier time when the API of components was still volatile). I have actually loaded these plugins and used them to construct a point cloud from a Primesense camera using a horrible hacky port of openni2_camera. |
@SteveMacenski circle ci is now passing! |
Thanks for the contribution! |
This makes them loadable with the rclcpp_components
interface. I've fully tested PointCloudXYZRGB and
ConvertMetric, my use case doesn't use the others.
I also lack a setup to test the launch files fully,
but ran them with the realsense commented out and
they appear to be OK.