Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ros2: variables undefined #713

Closed
azhural opened this issue Nov 25, 2021 · 3 comments
Closed

ros2: variables undefined #713

azhural opened this issue Nov 25, 2021 · 3 comments
Assignees
@mikeferguson
Labels
bug ros2

Comments

@azhural
Copy link

azhural commented Nov 25, 2021 •
edited

51a60e7 has introduced a fisheye_flags variable in camera_calibration's camera_calibrator.py L108, which is undefined. L153 reads self.checkerboard_flags, but should read self._checkerboard_flags.

After fixing that locally I ran into a boards undefined error. I'm unsure if that's user error.
@jonathanTIE jonathanTIE mentioned this issue Jan 22, 2022
Merged
@javadan javadan mentioned this issue Mar 11, 2022
Closed
@mikeferguson mikeferguson reopened this Jan 17, 2024
@mikeferguson
Copy link
Member

The _checkerboard_flags part is fixed - but not the boards issue

@mikeferguson mikeferguson self-assigned this Jan 19, 2024
@mikeferguson
Copy link
Member

Assigning to myself - going to run through the various calibration issues in the next two weeks

@mikeferguson
Copy link
Member

This appears to be correct in code at this point - can't really determine what the "boards error" was

mikeferguson pushed a commit that referenced this issue Feb 1, 2024
@jonathanTIE
calibration: better warnings around board configuration #713 (#724)
cdb7eb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeferguson mikeferguson

Labels
bug ros2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikeferguson @azhural