Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use cv::DestroyAllWindows #863

Merged
merged 1 commit into from
Jan 19, 2024
Merged

use cv::DestroyAllWindows #863

merged 1 commit into from
Jan 19, 2024

Conversation

mikeferguson
Copy link
Member

@mikeferguson mikeferguson commented Jan 19, 2024 •
edited
Loading

This ports #816 to ROS 2 and prevents weird exit conditions if you already closed the window

@mikeferguson mikeferguson changed the title port #816 to ROS 2 use cv::DestroyAllWindows Jan 19, 2024
@mikeferguson mikeferguson mentioned this pull request Jan 19, 2024
Closed
@ahcorde ahcorde merged commit 5645baa into ros-perception:rolling Jan 19, 2024
3 checks passed
ahcorde pushed a commit that referenced this pull request Jan 19, 2024
@mikeferguson @ahcorde
use cv::DestroyAllWindows (#863)
967e53f 
This ports #816 to ROS 2 and prevents weird exit conditions if you
already closed the window
ahcorde pushed a commit that referenced this pull request Jan 19, 2024
@mikeferguson @ahcorde
use cv::DestroyAllWindows (#863)
750db49 
This ports #816 to ROS 2 and prevents weird exit conditions if you
already closed the window
This was referenced Jan 19, 2024
Merged
Merged
@ahcorde
Copy link
Contributor

ahcorde commented Jan 19, 2024

backported to humble and iron

mikeferguson added a commit that referenced this pull request Jan 19, 2024
@ahcorde @mikeferguson
[backport Humble] use cv::DestroyAllWindows (#863) (#864)
6d5edd8 
This ports #816 to ROS 2 and prevents weird exit conditions if you
already closed the window

backport #863

Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
mikeferguson added a commit that referenced this pull request Jan 19, 2024
@ahcorde @mikeferguson
[backport Iron] use cv::DestroyAllWindows (#863) (#865)
b53764c 
This ports #816 to ROS 2 and prevents weird exit conditions if you
already closed the window

backport #863

Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
@mikeferguson mikeferguson deleted the rolling_816 branch January 19, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikeferguson @ahcorde