Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release image_transport_plugins to Noetic? #55

Closed
ahcorde opened this issue Apr 7, 2020 · 3 comments
Closed

Release image_transport_plugins to Noetic? #55

ahcorde opened this issue Apr 7, 2020 · 3 comments

Comments

@ahcorde
Copy link
Contributor

ahcorde commented Apr 7, 2020

Would you mind releasing image_transport_plugins to ROS Noetic? It looks like all of its dependencies have been released, and recursively 15 repos need it.

This changes should be enough #53

@sloretz
Copy link

sloretz commented May 12, 2020

@dgossow friendly ping. Mind making a Noetic release?

@sloretz
Copy link

sloretz commented May 13, 2020

@dgossow @vrabaud I'm looking to get this released into Noetic since metapackages depends on it. The tests pass for me locally in a Focal container using #53. Any objections to me doing the following?

  1. create noetic-devel branch from indigo-devel
  2. retarget Bump CMake version to avoid CMP0048 warning #53 at noetic-devel and squash-merge it
  3. tag noetic-devel as 1.14.0 (increased minor version by 1 for each ROS release since indigo in case you want to make releases for those distros in the future)
  4. release 1.14.0 with repo status unmaintained

If I don't hear anything in a day I'll assume the above is ok, hope you don't mind.

@sloretz
Copy link

sloretz commented May 15, 2020

ros/rosdistro#24918

@sloretz sloretz closed this as completed May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants