Ros2 devel #6
Merged
Ros2 devel #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial port of the laser_proc package to ros 2
Removing creation of private node handle which is not allowed in ROS 2.
when ament build add --isolated option
Fixed compile error: cannot find class_loader_register_macro.h when ament build add --isolated option
ros2 ardent compliant
Minor update to ROS 2 Bouncy
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
@chadrockey Do you mind having a look at this? Ideally, we would have this landed upstream and released in dashing/eloquent to push forward a release of the urg laser driver. |
clalancette
reviewed
Jan 2, 2020
Karsten1987
commented
Jan 3, 2020
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
with the latest commit I've addressed some of the review points, but more over changed quite some code which was unused and can now be handled more conveniently with the ROS2 component API. |
clalancette
reviewed
Jan 6, 2020
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Karsten1987
force-pushed
the
ros2-devel
branch
from
ca72616
to
99fe461
Compare
clalancette
approved these changes
Jan 6, 2020
|
@chadrockey Any thoughts on this PR? It looks good to me, so unless you have any thoughts or objections, @Karsten1987 or I will merge at the end of the week. |
|
All right, I'm going to go ahead and merge. If there are any comments you want to add, please feel free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fair mix of commits started by @bponsler and @MarcTestier in order to port laser_proc to ros2. I am opening this in order to have a single upstream port rather than multiple forks.
This is a pretty straight forward migration without any chances in design or code style.
A ros2 port of this is further needed to unblock the migration work of URG: ros-drivers/urg_node#50