Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified hough-circle for color circle #13

Merged
merged 2 commits into from
Aug 31, 2016
Merged

Modified hough-circle for color circle #13

merged 2 commits into from
Aug 31, 2016

Conversation

iory
Copy link
Contributor

@iory iory commented Jun 2, 2016

hough_circle

@k-okada
Copy link
Contributor

k-okada commented Jun 3, 2016

I think there are two cases for color or gray for 'frame' image
https://github.com/iory/opencv_apps/blob/1ffa870096a36d4e24d82a4c1a62e7e465d9d0d2/src/nodelet/hough_circles_nodelet.cpp#L146

@iory
Copy link
Contributor Author

iory commented Jun 3, 2016

in gray scale, we should output gray scale image?

@iory
Copy link
Contributor Author

iory commented Jun 3, 2016

https://github.com/iory/opencv_apps/blob/1ffa870096a36d4e24d82a4c1a62e7e465d9d0d2/src/nodelet/hough_circles_nodelet.cpp#L213-L215
This code is meaningless

k-okada
k-okada reviewed Aug 25, 2016
View reviewed changes
src/nodelet/hough_circles_nodelet.cpp
@@ -201,15 +201,18 @@ class HoughCirclesNodelet : public opencv_apps::Nodelet
min_circle_radius_,
max_circle_radius_ );

cv::Mat out_image;
cv::cvtColor( frame, out_image, cv::COLOR_GRAY2BGR);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frame can be both color and gray

@k-okada
Copy link
Contributor

k-okada commented Aug 25, 2016

this is conflict, please rebase

@iory
Copy link
Contributor Author

iory commented Aug 30, 2016

rebased

@k-okada k-okada merged commit c3bedc3 into ros-perception:indigo Aug 31, 2016
@k-okada
Copy link
Contributor

k-okada commented Aug 31, 2016

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iory @k-okada