Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bag_to_pcd does not support tf2 #46

Closed
LucidOne opened this issue Apr 7, 2014 · 2 comments
Closed

bag_to_pcd does not support tf2 #46

LucidOne opened this issue Apr 7, 2014 · 2 comments

Comments

@LucidOne
Copy link
Contributor

LucidOne commented Apr 7, 2014

Support for tf2 needed for Hydro and later

This is the quick way of fixing it.

Patch

diff --git a/pcl_ros/tools/bag_to_pcd.cpp b/pcl_ros/tools/bag_to_pcd.cpp
index b9114cf..d1ec14e 100644
--- a/pcl_ros/tools/bag_to_pcd.cpp
+++ b/pcl_ros/tools/bag_to_pcd.cpp
@@ -91,6 +91,7 @@ int

   view.addQuery (bag, rosbag::TypeQuery ("sensor_msgs/PointCloud2"));
   view.addQuery (bag, rosbag::TypeQuery ("tf/tfMessage"));
+  view.addQuery (bag, rosbag::TypeQuery ("tf2_msgs/TFMessage"));
   view_it = view.begin ();

   std::string output_dir = std::string (argv[3]);

If there is an example of the preferred migration approach I'd be happy to produce a patch.

@wjwwood
Copy link
Member

wjwwood commented Apr 7, 2014

Can you make that a pull request?

Github will make one for you, just edit the file here: https://github.com/ros-perception/perception_pcl/edit/hydro-devel/pcl_ros/tools/bag_to_pcd.cpp

@LucidOne
Copy link
Contributor Author

LucidOne commented Apr 7, 2014

Content preview: On 04/07/2014 04:10 PM, William Woodall wrote: > > Can you
make that a pull request? > > Github will make one for you, just edit the
file here: > https://github.com/ros-perception/perception_pcl/edit/hydro-devel/pcl_ros/tools/bag_to_pcd.cpp
> > — > Reply to this email directly or view it on GitHub > #46 (comment).
> No problem. [...]

Content analysis details: (-2.9 points, 5.0 required)

pts rule name description


-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]

On 04/07/2014 04:10 PM, William Woodall wrote:

Can you make that a pull request?

Github will make one for you, just edit the file here:
https://github.com/ros-perception/perception_pcl/edit/hydro-devel/pcl_ros/tools/bag_to_pcd.cpp


Reply to this email directly or view it on GitHub
#46 (comment).

No problem.

LucidOne added a commit that referenced this issue Apr 9, 2014
Tested with velodyne data on indigo on Ubuntu 14.04
paulbovbel pushed a commit that referenced this issue Apr 30, 2018
Tested with velodyne data on indigo on Ubuntu 14.04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants