Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for range_max is missing #19

Closed
moooeeeep opened this issue Jun 27, 2018 · 1 comment
Closed

Check for range_max is missing #19

moooeeeep opened this issue Jun 27, 2018 · 1 comment

Comments

@moooeeeep
Copy link

moooeeeep commented Jun 27, 2018

After the minimum range is checked here, the point is dropped when the value is smaller than range_min_.

Another check should be performed to also skip readings beyond the maximum range (threshold determined by the parameter range_max).

Example:

[...]
else if  (range > range_max_) {
    NODELET_DEBUG("rejected for range %f above maximum value %f. Point: (%f, %f, %f)", range, range_max_, *iter_x, *iter_y, *iter_z);
    continue;
}
[...]

Unfortunately I can't make a PR right now. Maybe I will get to that later.

@paulbovbel
Copy link
Member

Thanks for the report!

fmessmer added a commit to fmessmer/pointcloud_to_laserscan that referenced this issue Sep 26, 2020
…evel_and_freq_avoiding_log_spam

change log level and frequency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants