Fix default parameters in README #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some default parameters in the README file are wrong after looking at the source code https://github.com/ros-perception/pointcloud_to_laserscan/blob/rolling/src/pointcloud_to_laserscan_node.cpp#L58
clalancette
approved these changes
Jun 27, 2022
|
@Mergifyio backport galactic foxy |
mergify bot
pushed a commit
that referenced
this pull request
Jun 27, 2022
* Fix default parameters in README Some default parameters in the README file are wrong after looking at the source code https://github.com/ros-perception/pointcloud_to_laserscan/blob/rolling/src/pointcloud_to_laserscan_node.cpp#L58 Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit be047d2)
mergify bot
pushed a commit
that referenced
this pull request
Jun 27, 2022
* Fix default parameters in README Some default parameters in the README file are wrong after looking at the source code https://github.com/ros-perception/pointcloud_to_laserscan/blob/rolling/src/pointcloud_to_laserscan_node.cpp#L58 Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit be047d2)
✅ Backports have been created
|
clalancette
pushed a commit
that referenced
this pull request
Jun 27, 2022
* Fix default parameters in README Some default parameters in the README file are wrong after looking at the source code https://github.com/ros-perception/pointcloud_to_laserscan/blob/rolling/src/pointcloud_to_laserscan_node.cpp#L58 Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit be047d2) Co-authored-by: Carlos Andrés Álvarez Restrepo <charlie_cha@outlook.com>
clalancette
pushed a commit
that referenced
this pull request
Jun 27, 2022
* Fix default parameters in README Some default parameters in the README file are wrong after looking at the source code https://github.com/ros-perception/pointcloud_to_laserscan/blob/rolling/src/pointcloud_to_laserscan_node.cpp#L58 Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit be047d2) Co-authored-by: Carlos Andrés Álvarez Restrepo <charlie_cha@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some default parameters in the README file are wrong after looking at the source code https://github.com/ros-perception/pointcloud_to_laserscan/blob/rolling/src/pointcloud_to_laserscan_node.cpp#L58