Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove opencv2.cpp #480

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Remove opencv2.cpp #480

merged 2 commits into from
Sep 13, 2022

Conversation

ijnek
Copy link
Member

@ijnek ijnek commented Sep 12, 2022

Removes opencv2.cpp, and renames opencv3.cpp to opencv4.cpp to more closely match what's been done in noetic branch. Note that opencv4.cpp does contain an #ifdef for opencv3, so it still works with OpenCV3.

@wep21 Could you review this please?

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
@wep21
Copy link
Contributor

wep21 commented Sep 13, 2022

The changes are same as that in #323, so looks good to me.

@ijnek
Copy link
Member Author

ijnek commented Sep 13, 2022

Thanks @wep21

@ijnek ijnek merged commit 31946fe into ros-perception:rolling Sep 13, 2022
@ijnek ijnek deleted the ijnek-remove-opencv2.cpp branch September 13, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants