Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noetic release #323

Merged
merged 10 commits into from
Apr 3, 2020
Merged

Noetic release #323

merged 10 commits into from
Apr 3, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 23, 2020

Porting package from Melodic to Noetic

  • Removed Python2 dependencies
  • Updated to Opencv4

For some reason these formats are failing with opencv4: "ppm", "pgm", "pbm", I decided to remove them

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…thon3 issues

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@mjcarroll
Copy link
Contributor

Since maintainership of the ROS1 side of this has kind of fallen through the cracks, there are several PRs that cover the same ground:

#321, #312, #308, #288, #274, #259

This was referenced Mar 28, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 1, 2020

@ros-pull-request-builder retest this please

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 1, 2020

@ros-pull-request-builder retest this please

1 similar comment
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 1, 2020

@ros-pull-request-builder retest this please

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 1, 2020

@mjcarroll CI is passing here. Who is the mainteiner of this package?

@mjcarroll
Copy link
Contributor

I saw you updated some of the travis config, is it expected to pass?

Who is the mainteiner of this package?

@vrabaud is, but I think we can get this in to get noetic moving along.

@mjcarroll mjcarroll merged commit 88e01f8 into ros-perception:noetic Apr 3, 2020
mjcarroll pushed a commit that referenced this pull request Apr 6, 2020
* Python3 and Opencv4 changes - noetic

Signed-off-by: ahcorde <ahcorde@gmail.com>

* image_geometry cmake_minimum_required to 3.0.2

Signed-off-by: ahcorde <ahcorde@gmail.com>

* vision_opencv cmake_minimum_required to 3.0.2

Signed-off-by: ahcorde <ahcorde@gmail.com>

* opencv_test cmake_minimum_required to 3.0.2, fixed launch file and python3 issues

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Removed static_casst

Signed-off-by: ahcorde <ahcorde@gmail.com>

* import setup from setuptools instead of distutils-core

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Updated travis.yml and travis.sh

Signed-off-by: ahcorde <ahcorde@gmail.com>

* do_numpy_import change signature to void * and returns nullptr

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Updated keys

Signed-off-by: ahcorde <ahcorde@gmail.com>

* updated python3-numpy key

Signed-off-by: ahcorde <ahcorde@gmail.com>
@Stigmaru
Copy link

Is OpenCV4 or vision_opencv preinstalled into ROS Noetic or do I need to install OpenCV separately?

@ahcorde
Copy link
Contributor Author

ahcorde commented May 24, 2020

If you install these packages with apt-get install then the dependency is installed. If you are compiling them from source use ros-dep. This is the kind of question that you should ask in https://answers.ros.org/questions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants