geometry_msgs doesn't get used by opencv_apps, but std_msgs does. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasw
added a commit
to lucasw/xdo_ros
that referenced
this pull request
Mar 15, 2016
|
looks justified. Would a release be needed just for that ? |
vrabaud
added a commit
that referenced
this pull request
Mar 15, 2016
geometry_msgs doesn't get used by opencv_apps, but std_msgs does.
|
I don't think a release is needed, it could wait until some other changes pile up. Is there a way to see what released packages depend on opencv_apps? (Other than having local copy of every package source and grepping their package.xmls) If there are some and they could eliminate the geometry_msgs dependency that would be more motivation to release earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried making a package that used opencv_apps msgs, but then the build complained about geometry_msgs, which I thought opencv_apps ought to be putting into catkin_package()- but it looks like it doesn't need it at all.