Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appending to CMAKE_MODULE_PATH #22

Closed
peter-lehner opened this issue Sep 8, 2014 · 0 comments
Closed

Appending to CMAKE_MODULE_PATH #22

peter-lehner opened this issue Sep 8, 2014 · 0 comments

Comments

@peter-lehner
Copy link

I would like to specify my own FindQhull.cmake to your package externally, as I have the qhull include files and libraries in special paths (due to package management). This is currently not possible as you prepend your custom cmake module path to CMAKE_MODULE_PATH in https://github.com/ros-planning/geometric_shapes/blob/hydro-devel/CMakeLists.txt#L4. Would it be possible to instead append to the CMAKE_MODULE_PATH? This will only change the cmake find behaviour if someone else specifes a FindQhull.cmake file on the path as the CMAKE_MODULE_PATH is empty by default. If yes, I can provide a pull request.

v4hn added a commit to v4hn/warehouse_ros that referenced this issue Jun 15, 2016
Prepending is non-standard and breaks external overlays
as in moveit/geometric_shapes#22
@v4hn v4hn closed this as completed in ac82f16 Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant