Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log function deprecation warnings. #72

Merged

Conversation

Projects
None yet
3 participants
@mikepurvis
Copy link
Contributor

commented Oct 20, 2017

Closes #71.

@mikepurvis mikepurvis changed the title Fix log warnings. Fix log function deprecation warnings. Oct 20, 2017

@racko

This comment has been minimized.

Copy link

commented Jan 4, 2018

Since the release of console_bridge 0.4.0 (ros/console_bridge@c227ae0), these have turned from deprecation warnings into build errors:

.../geometric_shapes-release-release-lunar-geometric_shapes-0.5.3-0/src/body_operations.cpp:62:7: error: ‘logError’ was not declared in this scope
       logError("Creating body from shape: Unknown shape type %d", (int)shape->type);

Also, it seems that the change needs an update since your change does not touch body_operations.cpp, which has a number of logError occurrences.

@davetcoleman
Copy link
Member

left a comment

Thanks for fixing this regression

@davetcoleman davetcoleman merged commit 66ac8c5 into ros-planning:kinetic-devel Jan 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.