WIP: fix chomp issues #1377
Merged
WIP: fix chomp issues #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I take this is not yet ready to review, right? The changes so far look good! |
|
@bmagyar I hope we / you? can fix more of the chomp issues before releasing. That's why I marked this as wip. |
If the main planner fails, res.trajectory_ is NULL, and accessing it segfaults. Now, bail out in this case.
mayman99
pushed a commit
to mayman99/moveit
that referenced
this pull request
Mar 9, 2019
If the main planner fails, res.trajectory_ is NULL, and accessing it segfaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix various chomp issues.
res.trajectory_isNULL.Open issues:
When running plan+exec, the initial RobotState seems to be undefined, while it is defined otherwise.