-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor bug fixes in (collision) distance field #1392
Conversation
deleted void generateEnvironmentDistanceField(bool redo = true); No source exists.
fixed worldtogrid and gridtoworld world input vectors to doubles as required.
replaced hardcoded defaults
replaced hardcoded defaults with variables from robot_distance_field.
Thanks for helping in improving MoveIt! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @bmagyar, could you provide a second review?
@tsijs, please apply clang-format to fix Travis: |
Done:) |
...sion_distance_field/include/moveit/collision_distance_field/collision_distance_field_types.h
Outdated
Show resolved
Hide resolved
@henningkayser, can you have a look (again)? |
Congrats on getting your first MoveIt! pull request merged and improving open source robotics! |
Strictly speaking, this changes public API (from Vector3i to Vector3d). However, as this is a clear bug fix, I support cherry-picking this. @henningkayser, please, in future, clean up the commit message, when squash-merging on github. |
* Update collision_world_distance_field.h deleted void generateEnvironmentDistanceField(bool redo = true); No source exists. * Update voxel_grid.h fixed worldtogrid and gridtoworld world input vectors to doubles as required. * Update collision_robot_hybrid.h replaced hardcoded defaults * Update collision_world_hybrid.h replaced hardcoded defaults with variables from robot_distance_field. * apply clang-format
Description
Made some minor bug fixes in the distance field functionality.
Checklist