Minor bug fixes in (collision) distance field #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleted void generateEnvironmentDistanceField(bool redo = true); No source exists.
fixed worldtogrid and gridtoworld world input vectors to doubles as required.
replaced hardcoded defaults
replaced hardcoded defaults with variables from robot_distance_field.
|
Thanks for helping in improving MoveIt! |
|
@tsijs, please apply clang-format to fix Travis: |
|
Done:) |
...sion_distance_field/include/moveit/collision_distance_field/collision_distance_field_types.h
Outdated
Show resolved
Hide resolved
|
@henningkayser, can you have a look (again)? |
henningkayser
approved these changes
Apr 4, 2019
|
Congrats on getting your first MoveIt! pull request merged and improving open source robotics! |
Strictly speaking, this changes public API (from Vector3i to Vector3d). However, as this is a clear bug fix, I support cherry-picking this. @henningkayser, please, in future, clean up the commit message, when squash-merging on github. |
rhaschke
pushed a commit
to ubi-agni/moveit
that referenced
this pull request
May 11, 2019
* Update collision_world_distance_field.h deleted void generateEnvironmentDistanceField(bool redo = true); No source exists. * Update voxel_grid.h fixed worldtogrid and gridtoworld world input vectors to doubles as required. * Update collision_robot_hybrid.h replaced hardcoded defaults * Update collision_world_hybrid.h replaced hardcoded defaults with variables from robot_distance_field. * apply clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made some minor bug fixes in the distance field functionality.
Checklist