[Python wrapper] Added custom time limit for wait_for_servers in MoveGroupInterface #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Retained current hardcoded 5 second limit * Used double to conform to python accessible API instead of `ros::WallDuration(int, int)` * API is extended, remains conformant to previous releases
|
Thanks for helping in improving MoveIt! |
henningkayser
approved these changes
May 7, 2019
|
Congrats on getting your first MoveIt! pull request merged and improving open source robotics! |
BryceStevenWilley
removed
the
awaits 2nd review
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 30, 2020
…GroupInterface (moveit#1444) * Added custom time limit for wait_for_servers * Retained current hardcoded 5 second limit * Used double to conform to python accessible API instead of `ros::WallDuration(int, int)` * API is extended, remains conformant to previous releases * Ran clang-format on a webedit
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 31, 2020
…GroupInterface (moveit#1444) * Added custom time limit for wait_for_servers * Retained current hardcoded 5 second limit * Used double to conform to python accessible API instead of `ros::WallDuration(int, int)` * API is extended, remains conformant to previous releases * Ran clang-format on a webedit
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 31, 2020
…GroupInterface (moveit#1444) * Added custom time limit for wait_for_servers * Retained current hardcoded 5 second limit * Used double to conform to python accessible API instead of `ros::WallDuration(int, int)` * API is extended, remains conformant to previous releases * Ran clang-format on a webedit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ros::WallDuration(int, int)Would be nice if this was applied to Kinetic, Lunar and Melodic (all distros maintained next month)
Checklist