Fix jog arm integrationtest CI / array out-of-bounds #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and re-enable jog-arm integrationtest
drop hard-coded plain c array and directly add Eigen vectors without loop and start from non-singular robot state Fixes moveit#1435
|
@AndyZe please review. |
AndyZe
approved these changes
May 16, 2019
| delta_x[3] = vector_toward_singularity[3] / scale; | ||
| delta_x[4] = vector_toward_singularity[4] / scale; | ||
| delta_x[5] = vector_toward_singularity[5] / scale; | ||
| delta_x = vector_toward_singularity / scale; |
moveit_experimental/jog_arm/test/integration/test_jog_arm_integration.py
Outdated
Show resolved
Hide resolved
jschleicher
force-pushed
the
fix/jog_arm_integrationtest_5
branch
from
41a6d29
to
6861aec
Compare
It was still hard enough to track down. |
BryceStevenWilley
approved these changes
May 19, 2019
BryceStevenWilley
added
the
awaits 2nd review
rhaschke
approved these changes
May 19, 2019
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
May 12, 2020
* rename .test launch file and re-enable jog-arm integration test * fix array out-of-bounds access drop hard-coded plain c array and directly add Eigen vectors without loop * start from non-singular robot state
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
May 20, 2020
* rename .test launch file and re-enable jog-arm integration test * fix array out-of-bounds access drop hard-coded plain c array and directly add Eigen vectors without loop * start from non-singular robot state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drop hard-coded plain c array and directly add Eigen vectors without loop
and start from non-singular robot state. This fixes the travis CI integration test.
Checklist