-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark combinations of predefined poses #1548
Benchmark combinations of predefined poses #1548
Conversation
6741416
to
763f015
Compare
88b8c1a
to
16c5336
Compare
d97c5af
to
cd31c74
Compare
I added an example and fixed some conflicts with changes in the previous PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small requests
@@ -0,0 +1,31 @@ | |||
<launch> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems this should live in the tutorials... no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about that. There is already a set of similar examples. It's also really convenient to be able to customize these from within the main package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally the tutorials would live in this repo (future work)
in other components we've been keeping stuff like this in the tutorials, but your call.
we could move all of these examples into the tutorials... this package predates the moveit_tutorials repo
moveit_ros/benchmarks/examples/demo_panda_predefined_poses.yaml
Outdated
Show resolved
Hide resolved
916d16a
to
4acd3a7
Compare
I rebased feature-benchmark-improvements onto latest master, to fix the latest Travis issue (moveit_msgs was used from melodic-devel branch, but moveit_visual_tools was using master features already). However, this requires to rebase this PR branch as well. @henningkayser, could you please do so? |
virtual ~BenchmarkOptions(); | ||
|
||
/** \brief Set the ROS namespace the node handle should use for parameter lookup */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome documentation!
This benchmark allows conveniently planning trajectories between all pair-wise combinations of predefined poses that were specified in the benchmark config.
dea5b7d
to
e957484
Compare
The CombinePredefinedPosesBenchmark allows conveniently planning trajectories between all pair-wise combinations of predefined poses that are specified in the benchmark config.
Adds a benchmark executable that creates planner queries for all pair-wise combinations of named poses specified in the config.