Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark combinations of predefined poses #1548

Conversation

henningkayser
Copy link
Member

@henningkayser henningkayser commented Jul 10, 2019

Adds a benchmark executable that creates planner queries for all pair-wise combinations of named poses specified in the config.

@rhaschke rhaschke changed the base branch from master to feature-benchmark-improvements July 14, 2019 14:32
@henningkayser henningkayser changed the title [WIP] Benchmark combinations of predefined poses Benchmark combinations of predefined poses Aug 8, 2019
@henningkayser
Copy link
Member Author

henningkayser commented Aug 8, 2019

I added an example and fixed some conflicts with changes in the previous PRs.

Copy link
Member

@davetcoleman davetcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small requests

@@ -0,0 +1,31 @@
<launch>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems this should live in the tutorials... no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about that. There is already a set of similar examples. It's also really convenient to be able to customize these from within the main package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally the tutorials would live in this repo (future work)

in other components we've been keeping stuff like this in the tutorials, but your call.

we could move all of these examples into the tutorials... this package predates the moveit_tutorials repo

@rhaschke rhaschke force-pushed the feature-benchmark-improvements branch from 916d16a to 4acd3a7 Compare August 15, 2019 14:28
@rhaschke
Copy link
Contributor

I rebased feature-benchmark-improvements onto latest master, to fix the latest Travis issue (moveit_msgs was used from melodic-devel branch, but moveit_visual_tools was using master features already). However, this requires to rebase this PR branch as well. @henningkayser, could you please do so?

virtual ~BenchmarkOptions();

/** \brief Set the ROS namespace the node handle should use for parameter lookup */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome documentation!

@rhaschke rhaschke merged commit 2e2552f into moveit:feature-benchmark-improvements Aug 17, 2019
henningkayser added a commit to PickNikRobotics/moveit that referenced this pull request Nov 21, 2019
The CombinePredefinedPosesBenchmark allows conveniently planning trajectories between all
pair-wise combinations of predefined poses that are specified in the benchmark config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants