jog_arm: Use UR5 example #1605
Merged
jog_arm: Use UR5 example #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2019
Merged
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
May 12, 2020
Switch from Motoman to UR5 example. Add quick start instructions in README
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
May 20, 2020
Switch from Motoman to UR5 example. Add quick start instructions in README
sjahr
pushed a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
…er than bool (moveit#1605) * Return code rather than bool * Remove all debug prints * Small fixup * Minor cleanup of comment and error handling * void return from PlannerFn * Control reaches end of non-void function * Use a MoveItErrorCode cast * More efficient callAdapter() * More MoveItErrorCode * CI fixup attempt
sjahr
pushed a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
* Revert "Planning request adapters: short-circuit if failure, return code rather than bool (moveit#1605)" This reverts commit 66a64b4. * Add debug message in call stack of planning_request_adapters * Short-circuit planning request adapters * Replace if-elseif cascade with switch * Cleanup translation of MoveItErrorCode to string - Move default code to moveit_core/utils - Override defaults in existing getActionResultString() - Provide translations for all error codes defined in moveit_msgs * Fix comment according to review * Add braces Co-authored-by: Henning Kayser <henningkayser@picknik.ai> * Add braces Co-authored-by: Henning Kayser <henningkayser@picknik.ai> Co-authored-by: Henning Kayser <henningkayser@picknik.ai> Co-authored-by: AndyZe <andyz@utexas.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #1482 to resolve several merge conflicts. See conversation there for more details.
The previous PR was already approved by @mlautman.
@AndyZe, please have a look and address the remaining issues pointed out in #1482 (review) and #1482 (review).