Separate moveit_experimental packages #1606
Conversation
rhaschke
force-pushed
the
separate-experimental-pkgs
branch
from
31c75f9
to
3c5f3eb
Compare
| publish_joint_positions: true | ||
| publish_joint_velocities: false | ||
| publish_joint_accelerations: false | ||
|
|
rhaschke
force-pushed
the
separate-experimental-pkgs
branch
from
3c5f3eb
to
b046f55
Compare
| @@ -1,31 +1,68 @@ | |||
| set(JOG_ARM_NAME jog_arm) | |||
| cmake_minimum_required(VERSION 2.8.3) | |||
| project(jog_arm) | |||
There was a problem hiding this comment.
Are we happy naming this jog_arm or should this have a moveit prefix?
There was a problem hiding this comment.
I'm definitely agree to name this package moveit_jog_arm in order to distinguish it from the existing jog_arm package. Actually, I wanted to ask @AndyZe to apply this change after the present PR is merged ;-)
Do you think, it should be part of the present PR instead?
There was a problem hiding this comment.
Well, I like the shorter name.
jog_arm was never released as a debian for Melodic so there won't be a conflict there (and I don't mind removing the Kinetic debian from rosdistro). So don't worry about name conflicts.
There was a problem hiding this comment.
Made a PR to remove the old version of jog_arm from rosdistro here:
There was a problem hiding this comment.
All packages of the MoveIt universe are prefixed with moveit_. This should hold for jog_arm as well. That's the "downside" of your decision to migrate the package into MoveIt 😉
There was a problem hiding this comment.
I like moveit_jog_arm
The upside is we have really good tools in the moveit repo for code quality and maintenance :-)
Make jog_arm an own package located in the moveit_experimental folder.
rhaschke
force-pushed
the
separate-experimental-pkgs
branch
from
b4b7412
to
f37dd26
Compare
|
You're right, renaming does not have to be part of this request. @rhaschke , you mentioned you merge and push pull-requests almost exclusively on the command line. I just tried to squash your commits and merge (granted, this triggers the old squash-vs-plain-merge debate) from my system (opposed to the github web page), but the repository setup does not let me push, saying: How do you handle this in your review process? I am rather unhappy with safety measures that make it impossible to work with git the conventional way, @davetcoleman . |
|
@v4hn, I perform the review process locally, but usually, I use github's web interface to finally merge. |
|
;-) |
* Make jog_arm an own package located in the moveit_experimental folder. * adapt package location * minor cleanup
* Make jog_arm an own package located in the moveit_experimental folder. * adapt package location * minor cleanup
* Make jog_arm an own package located in the moveit_experimental folder. * adapt package location * minor cleanup
* Make jog_arm an own package located in the moveit_experimental folder. * adapt package location * minor cleanup
* Make jog_arm an own package located in the moveit_experimental folder. * adapt package location * minor cleanup
This is a replacement for #1549, factoring out all packages in
moveit_experimentalas proper ROS packages. This allows to build them separately as intended by #1549.Currently, only
jog_armis enabled, all other packages are catkin-ignored (some of them are not even catkinized yet). In contrast to #1549, this PR leaves all folders in their place.That is,
moveit_experimentaljust acts as a container folder for these packages.As we don't plan to release
moveit_experimenalpackages, there is no need to define a corresponding meta package.Thus this PR depends on the former being merged first.