[windows][master] Use ros::Duration::sleep for portability. #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanyen
requested review from
davetcoleman,
henningkayser and
rhaschke
as code owners
gavanderhoorn
approved these changes
Aug 21, 2019
|
Merging. This is a trivial cleanup. Actually, a number of these could be rewritten in a way to avoid the sleep, but it's mostly minor demo code where timing does not really matter. |
henningkayser
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
Nov 21, 2019
rhaschke
pushed a commit
to ubi-agni/moveit
that referenced
this pull request
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some code paths, it uses
POSIXsleep. However, fornon-POSIXsystems, thesleepmay not exist. This change is to use the abstractros::Duration::sleepfor portability.