Rename jog_arm->moveit_jog_arm #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
requested changes
Sep 9, 2019
moveit_experimental/moveit_jog_arm/include/moveit_jog_arm/collision_check_thread.h
Outdated
Show resolved
Hide resolved
moveit_experimental/moveit_jog_arm/include/moveit_jog_arm/collision_check_thread.h
Outdated
Show resolved
Hide resolved
rhaschke
approved these changes
Sep 18, 2019
davetcoleman
approved these changes
Sep 19, 2019
There was a problem hiding this comment.
Looks good, thanks!
Note you don't need my second review to merge this as @AndyZe is a Core Contributor on the webpage:
Quicker code contributions: you only need one review to get your code merged in, while non-maintainer/non-core contributor pull requests require two approvals.
henningkayser
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
Nov 21, 2019
* Rename jog_arm->moveit_jog_arm * Address @rhaschke's feedback * apply clang-format
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
May 12, 2020
* Rename jog_arm->moveit_jog_arm * Address @rhaschke's feedback * apply clang-format
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
May 12, 2020
* Rename jog_arm->moveit_jog_arm * Address @rhaschke's feedback * apply clang-format
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
May 20, 2020
* Rename jog_arm->moveit_jog_arm * Address @rhaschke's feedback * apply clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1612