Use MOVEIT_CLASS_FORWARD for moveit classes in moveit_ros. (#182) #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,6 +38,8 @@ | |||
| #ifndef MOVEIT_MOVE_GROUP_INTERFACE_MOVE_GROUP_ | |||
| #define MOVEIT_MOVE_GROUP_INTERFACE_MOVE_GROUP_ | |||
|
|
|||
| #include <moveit/macros/class_forward.h> | |||
| #include <moveit/macros/deprecation.h> | |||
There was a problem hiding this comment.
The #include <moveit/macros/deprecation.h> came from a different PR. There's no harm I suppose, but the include is probably not needed.
|
One line comment above, but looks good to me :) |
davetcoleman
force-pushed
the
indigo-class-forward
branch
from
90e617d
to
d4ab4e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #182
I got a conflict while merging so will check via PR