Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce console output warnings #1845

Merged
merged 4 commits into from
Jan 21, 2020
Merged

Reduce console output warnings #1845

merged 4 commits into from
Jan 21, 2020

Conversation

davetcoleman
Copy link
Member

  • jog_arm loads a PSM which always had a warning because no tf_buffer was loaded.
  • A number of ROS_INFOs I thought were unnecessary, so I moved to DEBUG
  • Made one warning more useful

@davetcoleman davetcoleman requested review from henningkayser and AndyZe and removed request for v4hn, mamoll and BryceStevenWilley January 20, 2020 20:39
AndyZe
AndyZe approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

rhaschke
rhaschke approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree to most changes except one.
Have pushed a fixup commit. Approving with this change.

moveit_experimental/moveit_jog_arm/src/collision_check_thread.cpp Outdated
@@ -52,7 +53,7 @@ CollisionCheckThread::CollisionCheckThread(const moveit_jog_arm::JogArmParameter
ros::Duration(WHILE_LOOP_WAIT).sleep();
}

planning_scene_monitor_.reset(new planning_scene_monitor::PlanningSceneMonitor(model_loader_ptr));
planning_scene_monitor_ = std::make_shared<planning_scene_monitor::PlanningSceneMonitor>(model_loader_ptr, std::make_shared<tf2_ros::Buffer>());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be reverted.
Passing a TF buffer that is not connected to a TF listener, doesn't make sense.

The key is to avoid setting up an Octomap Monitor, because we don't have a valid TF listener.
I will prepare a corresponding fixup commit.

@codecov-io
Copy link

Codecov Report

Merging #1845 into master will decrease coverage by 0.03%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1845      +/-   ##
==========================================
- Coverage    48.5%   48.46%   -0.04%     
==========================================
  Files         298      298              
  Lines       23302    23305       +3     
==========================================
- Hits        11302    11295       -7     
- Misses      12000    12010      +10
Impacted Files Coverage Δ
...ccupancy_map_monitor/src/occupancy_map_monitor.cpp 29.65% <0%> (-0.69%) ⬇️
...ntal/moveit_jog_arm/src/collision_check_thread.cpp 89.74% <100%> (-0.51%) ⬇️
...s/planning_interface/moveit_cpp/src/moveit_cpp.cpp 62.29% <100%> (ø) ⬆️
...lanners/ompl/ompl_interface/src/ompl_interface.cpp 71.42% <50%> (ø) ⬆️
...veit_experimental/moveit_jog_arm/src/jog_calcs.cpp 66.55% <0%> (-3.04%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 56.79% <0%> (+0.15%) ⬆️
...ler_manager/src/moveit_fake_controller_manager.cpp 64.21% <0%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a9e4b...c5b589a. Read the comment docs.

@henningkayser henningkayser merged commit 3a57141 into moveit:master Jan 21, 2020
@davetcoleman davetcoleman deleted the reduce_console_warnings branch January 21, 2020 15:14
@tylerjw tylerjw mentioned this pull request May 8, 2020
Closed
20 tasks
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
@davetcoleman @rhaschke @tylerjw
Reduce console output warnings (moveit#1845)
a9ddfb9 
* Reduce console output warnings

* jog_arm: cleanup PSM setup

* clang-format

* fix cut-and-paste error

Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
@davetcoleman @rhaschke @tylerjw
Reduce console output warnings (moveit#1845)
9ed4037 
* Reduce console output warnings

* jog_arm: cleanup PSM setup

* clang-format

* fix cut-and-paste error

Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 20, 2020
@davetcoleman @rhaschke @tylerjw
Reduce console output warnings (moveit#1845)
fa76632 
* Reduce console output warnings

* jog_arm: cleanup PSM setup

* clang-format

* fix cut-and-paste error

Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
sjahr pushed a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
@AndyZe
Add a question about RMW type to the issue template (moveit#1845)
7cab341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningkayser henningkayser henningkayser approved these changes

@rhaschke rhaschke rhaschke approved these changes

@AndyZe AndyZe AndyZe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davetcoleman @codecov-io @henningkayser @rhaschke @AndyZe