-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows][master] Fix various build breaks found in Windows build #1880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the addition of zlib fails on Linux, as zlib is usually not part of boost. Please fix.
Thanks. I added a conditional guard on this. Waiting for the CI result... |
Codecov Report
@@ Coverage Diff @@
## master #1880 +/- ##
=======================================
Coverage 50.26% 50.26%
=======================================
Files 313 313
Lines 24622 24622
=======================================
Hits 12377 12377
Misses 12245 12245 Continue to review full report at Codecov.
|
CI looks green now. |
@rhaschke This is ready for review again. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me now. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately we don't have a Windows CI set up, but @seanyen has built this, so 👍
Description
Fix various build breaks found in Windows build:
MSVC
.zlib
as a dependency to look for inBoost
. (On Windows,boost::iostreams
depends onboost::zlib
at linkage time.)glut
andGLEW
with the CMake variables.Checklist