Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CATKIN_DEPENDS: catkin_lint 1.6.7 #1987

Merged
merged 1 commit into from Mar 27, 2020
Merged

Fix CATKIN_DEPENDS: catkin_lint 1.6.7 #1987

merged 1 commit into from Mar 27, 2020

Conversation

henningkayser
Copy link
Member

@henningkayser henningkayser commented Mar 27, 2020 •
edited

CI was failing because of missing CATKIN_DEPENDS errors from catkin_lint 1.6.7

See https://travis-ci.org/github/ros-planning/moveit/jobs/667658214#L694

@henningkayser henningkayser changed the title Fix errors: catkin_lint 1.6.7 Fix CATKIN_DEPENDS: catkin_lint 1.6.7 Mar 27, 2020
rhaschke
rhaschke approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@rhaschke rhaschke merged commit 490622f into moveit:master Mar 27, 2020
@v4hn
Copy link
Contributor

v4hn commented Mar 27, 2020

Interesting to see a version update (1.6.6-1.6.7) break CI between a pull-request and the merged commit.
Thanks for the cleanup. I keep wondering how such issues have not been noticed/fixed years ago...

rhaschke pushed a commit to ubi-agni/moveit that referenced this pull request Mar 28, 2020
@henningkayser @rhaschke
Fix errors: catkin_lint 1.6.7 (moveit#1987)
2afabdd
@rhaschke rhaschke mentioned this pull request Mar 28, 2020
Merged
rhaschke pushed a commit to ubi-agni/moveit that referenced this pull request Mar 28, 2020
@henningkayser @rhaschke
Fix errors: catkin_lint 1.6.7 (moveit#1987)
7d0cc82
rhaschke added a commit that referenced this pull request Mar 28, 2020
@rhaschke
Fix errors: catkin_lint 1.6.7 (#1987)
0b412be
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request Mar 28, 2020
@henningkayser @tylerjw
Fix errors: catkin_lint 1.6.7 (moveit#1987)
fecd26d
@tylerjw tylerjw mentioned this pull request May 8, 2020
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaschke rhaschke rhaschke approved these changes

@bmagyar bmagyar Awaiting requested review from bmagyar

@BryceStevenWilley BryceStevenWilley Awaiting requested review from BryceStevenWilley

@gavanderhoorn gavanderhoorn Awaiting requested review from gavanderhoorn gavanderhoorn is a code owner

@IanTheEngineer IanTheEngineer Awaiting requested review from IanTheEngineer

@jrgnicho jrgnicho Awaiting requested review from jrgnicho

@mamoll mamoll Awaiting requested review from mamoll mamoll is a code owner

@mikeferguson mikeferguson Awaiting requested review from mikeferguson mikeferguson is a code owner

@v4hn v4hn Awaiting requested review from v4hn v4hn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@henningkayser @v4hn @rhaschke