Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jog_arm] time-based collision avoidance #2100

Merged
merged 8 commits into from
Jun 3, 2020
Merged

[jog_arm] time-based collision avoidance #2100

merged 8 commits into from
Jun 3, 2020

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented May 21, 2020

The old collision avoidance algorithm used manually-defined thresholds. This adds a new algorithm based on how fast the collision is approaching. It's optional, as you can see from the yaml file.

Video of it in action:

https://drive.google.com/file/d/1vMrrtflJme3Hexfo-685rKVS7uWIy14s/view?usp=sharing

@v4hn
Copy link
Contributor

v4hn commented May 21, 2020

You forgot the video 😄

@henningkayser
Copy link
Member

General approach looks good to me. I see that it makes a lot of sense to throttle the motion dynamically. Is there a reason we don't apply both methods at the same time so that the user decides how to set this up, i.e. you could throttle scene collisions with the first method and then only use the second method for self collisions by setting the distance/threshold parameters.

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #2100 into master will increase coverage by 0.03%.
The diff coverage is 55.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2100      +/-   ##
==========================================
+ Coverage   57.79%   57.83%   +0.03%     
==========================================
  Files         328      327       -1     
  Lines       25664    25580      -84     
==========================================
- Hits        14833    14793      -40     
+ Misses      10831    10787      -44     
Impacted Files Coverage Δ
...rm/include/moveit_jog_arm/collision_check_thread.h 100.00% <ø> (ø)
...veit_jog_arm/include/moveit_jog_arm/jog_arm_data.h 100.00% <ø> (ø)
...veit_experimental/moveit_jog_arm/src/jog_calcs.cpp 70.93% <28.57%> (-2.05%) ⬇️
...ntal/moveit_jog_arm/src/collision_check_thread.cpp 80.59% <47.61%> (-9.97%) ⬇️
...rimental/moveit_jog_arm/src/jog_interface_base.cpp 72.79% <76.92%> (-0.23%) ⬇️
.../ompl_interface/src/detail/constrained_sampler.cpp 46.15% <0.00%> (-17.95%) ⬇️
...s/ompl/ompl_interface/src/ompl_planner_manager.cpp 54.68% <0.00%> (-3.13%) ⬇️
...ma_kinematics_plugin/src/lma_kinematics_plugin.cpp 78.94% <0.00%> (-2.26%) ⬇️
...ng_interface/moveit_cpp/src/planning_component.cpp 48.76% <0.00%> (-1.24%) ⬇️
...veit_core/robot_model/src/revolute_joint_model.cpp 89.76% <0.00%> (-0.72%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736219d...e375bc3. Read the comment docs.

@AndyZe AndyZe requested a review from henningkayser May 28, 2020 13:58
@AndyZe AndyZe changed the title A minimum-stopping-time collision avoidance algorithm [jog_arm] time-based collision avoidance May 29, 2020
@AndyZe AndyZe changed the title [jog_arm] time-based collision avoidance WIP [jog_arm] time-based collision avoidance May 29, 2020
@AndyZe AndyZe changed the title WIP [jog_arm] time-based collision avoidance [jog_arm] time-based collision avoidance May 29, 2020
@AndyZe AndyZe requested a review from tylerjw May 29, 2020 13:46
Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through these and they look good. I like the idea of these changes to how collision avoidance works. I restarted your travis run as I think the issue with clang-tidy has been resolved.

@mlautman mlautman merged commit 85ff93b into moveit:master Jun 3, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request Jun 24, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request Jun 24, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request Jun 24, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request Jun 24, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request Jun 24, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request Jun 29, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants