-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jog_arm] time-based collision avoidance #2100
[jog_arm] time-based collision avoidance #2100
Conversation
You forgot the video 😄 |
moveit_experimental/moveit_jog_arm/src/collision_check_thread.cpp
Outdated
Show resolved
Hide resolved
General approach looks good to me. I see that it makes a lot of sense to throttle the motion dynamically. Is there a reason we don't apply both methods at the same time so that the user decides how to set this up, i.e. you could throttle scene collisions with the first method and then only use the second method for self collisions by setting the distance/threshold parameters. |
Codecov Report
@@ Coverage Diff @@
## master #2100 +/- ##
==========================================
+ Coverage 57.79% 57.83% +0.03%
==========================================
Files 328 327 -1
Lines 25664 25580 -84
==========================================
- Hits 14833 14793 -40
+ Misses 10831 10787 -44
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read through these and they look good. I like the idea of these changes to how collision avoidance works. I restarted your travis run as I think the issue with clang-tidy has been resolved.
The old collision avoidance algorithm used manually-defined thresholds. This adds a new algorithm based on how fast the collision is approaching. It's optional, as you can see from the yaml file.
Video of it in action:
https://drive.google.com/file/d/1vMrrtflJme3Hexfo-685rKVS7uWIy14s/view?usp=sharing