Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSA: Allow to show both, visual and collision geometry #2352

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Oct 6, 2020

Fixes #780. Note, that this builds on top of #2349!

@rhaschke rhaschke requested a review from v4hn October 6, 2020 00:13
@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #2352 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2352      +/-   ##
==========================================
+ Coverage   56.63%   56.64%   +0.02%     
==========================================
  Files         281      281              
  Lines       25457    25457              
==========================================
+ Hits        14415    14418       +3     
+ Misses      11042    11039       -3     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 68.32% <0.00%> (-0.14%) ⬇️
...ipulation/pick_place/src/manipulation_pipeline.cpp 75.00% <0.00%> (+0.97%) ⬆️
...meterization/work_space/pose_model_state_space.cpp 83.00% <0.00%> (+1.37%) ⬆️
...terface/parameterization/model_based_state_space.h 76.00% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8889901...99f7394. Read the comment docs.

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a real nice usability improvement. My only feedback is that it would be nice if it showed joints red if in collision and green when not in the edit pose screen (instead of all red for the group). But I'm approving as that is extra work and this is a major quality life of improvement as is.

@rhaschke
Copy link
Contributor Author

rhaschke commented Oct 6, 2020

My only feedback is that it would be nice if it showed joints red if in collision and green when not? in the edit pose screen.

Please file a corresponding issue ;-)
Not sure, though, rviz will colorize the collision mesh at all. (I never have seen it other than red.)

@rhaschke rhaschke merged commit b4e26cf into moveit:master Oct 6, 2020
@rhaschke rhaschke deleted the msa-collision-view branch October 6, 2020 22:50
@tylerjw tylerjw mentioned this pull request Oct 23, 2020
57 tasks
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Oct 23, 2020
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup assistant does not show collision geometries
2 participants