-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty sequence in moveit_setup_assistant #2406
Conversation
Not required for approval but @mohmadAyman adding this feature during his GSoC program 7097464 |
This is similar to #1680. |
Codecov Report
@@ Coverage Diff @@
## master #2406 +/- ##
==========================================
- Coverage 60.22% 60.20% -0.01%
==========================================
Files 352 352
Lines 26402 26402
==========================================
- Hits 15898 15893 -5
- Misses 10504 10509 +5
Continue to review full report at Codecov.
|
Would be nice, if the empty list would follow the commented example, like this: initial: # Define initial robot poses.
# - group: group
# pose: home
[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and it works as described.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing it!
* (moveit_py) add trajectory execution manager * (moveit_py) add __bool__ to ExecutionStatus * (moveit_py) Update copyright header of changed files * (moveit_py) add comment referencing issue * Rename init_trajectory_execution_manager -> initTrajectoryExecutionManager * (moveit_py) python functions snake_case * (moveit_py) fix styling ---------
Description
There's a bug right now in the generation of fake_controllers.yaml such that if no poses are found, it will output invalid yaml.
(and then the end of the file)
This results in a cryptic error like
With this PR, it now generates
Checklist