Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify logic in PSM #2632

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Apr 29, 2021

I rebased the patches from #2563 onto master. Assuming CI succeeds, this can be merged (it was reviewed before) and directly backported to melodic-devel as the original author proposed the PR for melodic-devel.

@v4hn v4hn requested a review from rhaschke as a code owner April 29, 2021 12:30
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #2632 (f8ba13f) into master (27c8a13) will decrease coverage by 0.11%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2632      +/-   ##
==========================================
- Coverage   60.52%   60.42%   -0.10%     
==========================================
  Files         402      402              
  Lines       29619    29241     -378     
==========================================
- Hits        17923    17665     -258     
+ Misses      11696    11576     -120     
Impacted Files Coverage Δ
...sion_plugin_loader/src/collision_plugin_loader.cpp 40.00% <50.00%> (+4.87%) ⬆️
...nning_scene_monitor/src/planning_scene_monitor.cpp 67.21% <100.00%> (-1.46%) ⬇️
.../ompl_interface/src/detail/constrained_sampler.cpp 43.25% <0.00%> (-16.21%) ⬇️
...ove_group_interface/src/wrap_python_move_group.cpp 35.11% <0.00%> (-2.93%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 83.34% <0.00%> (-0.64%) ⬇️
...raint_samplers/src/default_constraint_samplers.cpp 83.89% <0.00%> (-0.32%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 50.68% <0.00%> (-0.09%) ⬇️
...e/collision_detection_fcl/src/collision_common.cpp 78.61% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27c8a13...f8ba13f. Read the comment docs.

@JafarAbdi JafarAbdi merged commit f62c30f into moveit:master Apr 30, 2021
JafarAbdi pushed a commit to JafarAbdi/moveit that referenced this pull request Apr 30, 2021
Co-authored-by: Rojas Rafael <rafael.rojas@unibz.it>
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Apr 30, 2021
Co-authored-by: Rojas Rafael <rafael.rojas@unibz.it>
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Apr 30, 2021
Co-authored-by: Rojas Rafael <rafael.rojas@unibz.it>
v4hn pushed a commit that referenced this pull request Apr 30, 2021
Co-authored-by: Rojas Rafael <rafael.rojas@unibz.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants