Print error before returning #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print an error indicating that the planning pipelines are empty before returning
|
Thanks for helping in improving MoveIt and open source robotics! |
v4hn
approved these changes
Apr 30, 2021
|
I fail to understand how that ever passed review when it was added... Thanks for pointing it out! |
|
Congrats on getting your first MoveIt pull request merged and improving open source robotics! |
No problem! I think I was hitting it so I figured I'd make the fix. |
rhaschke
pushed a commit
to ubi-agni/moveit
that referenced
this pull request
May 23, 2021
Print an error indicating that the planning pipelines are empty before returning
rhaschke
pushed a commit
to ubi-agni/moveit
that referenced
this pull request
May 23, 2021
Print an error indicating that the planning pipelines are empty before returning
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Print an error indicating that the planning pipelines are empty before returning. It was previously just switched around in the code, so it returned before getting a chance as to complain.
Checklist