Make CI pedantic

[v4hn]

We rely on C++14 and should enforce standard-compliance (not just warning-free builds).

Potential followup to #2687

Let's see if anything/what breaks.

[codecov]

Codecov Report

Merging #2691 (ac8bad6) into master (cc65448) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2691      +/-   ##
==========================================
+ Coverage   60.55%   60.57%   +0.03%     
==========================================
  Files         402      402              
  Lines       29615    29615              
==========================================
+ Hits        17930    17936       +6     
+ Misses      11685    11679       -6     

Impacted Files	Coverage Δ
...ion_bullet/bullet_integration/bullet_bvh_manager.h	0.00% <ø> (ø)
...ullet/bullet_integration/bullet_cast_bvh_manager.h	100.00% <ø> (ø)
...t/bullet_integration/bullet_discrete_bvh_manager.h	100.00% <ø> (ø)
...detection_bullet/bullet_integration/bullet_utils.h	80.90% <ø> (ø)
...n_distance_field/collision_common_distance_field.h	93.34% <ø> (ø)
...on_distance_field/collision_distance_field_types.h	56.58% <ø> (ø)
...sion_distance_field/collision_env_distance_field.h	13.34% <ø> (ø)
...e/include/moveit/kinematics_base/kinematics_base.h	74.08% <ø> (ø)
...moveit/ompl_interface/detail/constraints_library.h	28.58% <ø> (ø)
...al_motion_planner/pilz_industrial_motion_planner.h	100.00% <ø> (ø)
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc65448...ac8bad6. Read the comment docs.

[v4hn]

Turns out the inconsistent semicolons where the only issue we had w.r.t. -pedantic builds.

I'd propose to merge this now.

[rhaschke]

Looks good to me. Thanks for the cleanup!