[fix] RobotState Constructor segfault

[tylerjw]

Description

This is a backport of a bug I fixed in moveit2.

It came from this PR: https://github.com/ros-planning/moveit2/pull/562/files

I am backporting the bug fix separate from that full PR because I believe it should be trivial to merge whereas that whole PR might require more discussion before we backport that pattern from moveit2 to moveit. That doesn't mean that we can't backport the bugs we fix while applying that pattern even if we don't want to backport the pattern yet.

[tylerjw]

  Error while processing /home/runner/work/moveit/moveit/.work/target_ws/src/moveit/moveit_core/robot_state/src/robot_state.cpp.
  error: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [clang-diagnostic-unknown-warning-option]
  /home/runner/work/moveit/moveit/.work/target_ws/src/moveit/moveit_core/robot_state/src/robot_state.cpp:1583:30: error: expression with side effects will be evaluated despite being used as an operand to 'typeid' [clang-diagnostic-potentially-evaluated-expression]
                        typeid(*solver).name(), jmg->getName().c_str(), error_msg.c_str());
                               ^

oh joy 😢

[codecov]

Codecov Report

Merging #2790 (dc85ea8) into master (86174f3) will decrease coverage by 0.02%.
The diff coverage is 66.67%.

@@            Coverage Diff             @@
##           master    #2790      +/-   ##
==========================================
- Coverage   60.44%   60.42%   -0.01%     
==========================================
  Files         366      366              
  Lines       31673    31675       +2     
==========================================
- Hits        19140    19136       -4     
- Misses      12533    12539       +6     

Impacted Files	Coverage Δ
moveit_core/robot_state/src/robot_state.cpp	50.43% <66.67%> (-<0.01%)	⬇️
.../ompl_interface/src/detail/constrained_sampler.cpp	43.25% <0.00%> (-16.21%)	⬇️
...meterization/work_space/pose_model_state_space.cpp	80.51% <0.00%> (-0.62%)	⬇️
...ipulation/pick_place/src/manipulation_pipeline.cpp	71.30% <0.00%> (+1.86%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86174f3...dc85ea8. Read the comment docs.

[v4hn]

Might have been triggered by 55886f7 .
See #2792 for my attempt to fix these warnings.