Fixes *_planning_pipeline.launch template input args defaults #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
force-pushed
the
makes_moveit_setup_assistant_input_args_default
branch
from
32f7247
to
c0f23a9
Compare
This was referenced Aug 27, 2021
rhaschke
reviewed
Aug 27, 2021
...tup_assistant/templates/moveit_config_pkg_template/launch/chomp_planning_pipeline.launch.xml
Outdated
Show resolved
Hide resolved
...etup_assistant/templates/moveit_config_pkg_template/launch/ompl_planning_pipeline.launch.xml
Outdated
Show resolved
Hide resolved
...oveit_config_pkg_template/launch/pilz_industrial_motion_planner_planning_pipeline.launch.xml
Outdated
Show resolved
Hide resolved
...p_assistant/templates/moveit_config_pkg_template/launch/trajopt_planning_pipeline.launch.xml
Outdated
Show resolved
Hide resolved
rickstaa
force-pushed
the
makes_moveit_setup_assistant_input_args_default
branch
from
c0f23a9
to
44c4de6
Compare
This commit makes sure that all input arguments of the *_planning_pipeline.launch templates do have a default value.
rickstaa
force-pushed
the
makes_moveit_setup_assistant_input_args_default
branch
from
44c4de6
to
45ab275
Compare
rhaschke
approved these changes
Aug 27, 2021
|
@rhaschke Good points, can't believe I missed that. I fixed these issues and rebased the branch. |
Codecov Report
@@ Coverage Diff @@
## master #2849 +/- ##
==========================================
- Coverage 60.87% 60.84% -0.02%
==========================================
Files 366 366
Lines 31705 31705
==========================================
- Hits 19296 19288 -8
- Misses 12409 12417 +8
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes sure that all input arguments of the *_planning_pipeline.launch templates do have a default value.