use default copy constructor to clone attached object #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonschmeisser
requested review from
felixvd,
mlautman and
rhaschke
as code owners
v4hn
approved these changes
Aug 28, 2021
| @@ -177,9 +177,7 @@ void RobotState::copyFrom(const RobotState& other) | |||
| // copy attached bodies | |||
| clearAttachedBodies(); | |||
| for (const std::pair<const std::string, AttachedBody*>& it : other.attached_body_map_) | |||
| attachBody(it.second->getName(), it.second->getPose(), it.second->getShapes(), it.second->getShapePoses(), | |||
| it.second->getTouchLinks(), it.second->getAttachedLinkName(), it.second->getDetachPosture(), | |||
| it.second->getSubframes()); | |||
Codecov Report
@@ Coverage Diff @@
## master #2855 +/- ##
==========================================
+ Coverage 60.85% 60.86% +0.02%
==========================================
Files 366 366
Lines 31712 31710 -2
==========================================
+ Hits 19296 19298 +2
+ Misses 12416 12412 -4
Continue to review full report at Codecov.
|
rhaschke
approved these changes
Aug 29, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon this when helping @felixvd debug #2854 ... this PR would have prevented his long despair
C++ provides a default copy constructor if it reasonably can.
AttachedBodyis a simple data structure so indeed it can here. Using the copy constructor prevents forgetting to manually copy some member variables.