Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waypoint duration to the trajectory deep copy unit test #2961

Merged
merged 3 commits into from Nov 16, 2021

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented Nov 15, 2021

Previously, only joint positions were tested.

This should settle the discussion here (PR #2957). The duration deep copy was correct, it seems.

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #2961 (2d812e5) into master (4db626d) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2961      +/-   ##
==========================================
- Coverage   61.59%   61.54%   -0.04%     
==========================================
  Files         370      370              
  Lines       33101    33104       +3     
==========================================
- Hits        20386    20372      -14     
- Misses      12715    12732      +17     
Impacted Files Coverage Δ
.../ompl_interface/src/detail/constrained_sampler.cpp 43.91% <0.00%> (-17.07%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.66% <0.00%> (-2.24%) ⬇️
...raint_samplers/src/default_constraint_samplers.cpp 79.60% <0.00%> (-0.28%) ⬇️
...t_setup_assistant/src/tools/moveit_config_data.cpp 15.40% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4db626d...2d812e5. Read the comment docs.

@AndyZe AndyZe force-pushed the andyz/unit_test_trajectory_duration branch from c5d4b83 to 2d812e5 Compare November 16, 2021 17:51
@v4hn v4hn merged commit d0d76f1 into moveit:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants