msa: cleanup yaml parsing #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,8 +127,7 @@ void operator>>(const YAML::Node& node, T& i) | |||
| typedef const YAML::Node* yaml_node_t; | |||
|
|
|||
| // Helper function to find a value (yaml-cpp 0.3) | |||
There was a problem hiding this comment.
can we just remove support for yaml-cpp 0.3 at this point?
There was a problem hiding this comment.
yaml-cpp 0.3 is default for Ubuntu 14.04 / ROS Indigo. In the Kinetic branch, indeed we could get rid of 0.3 support.
|
@davetcoleman I removed yaml 0.3 support and further simplified the yaml parsing code. |
- limit findValue to std::string key using templates for char[N] is ineffient, as every literal of new length N requires a new template instance - use boost::optional constructor to return value
rhaschke
force-pushed
the
msa-yaml-parsing
branch
from
049e9d6
to
42691db
Compare
davetcoleman
approved these changes
Mar 26, 2018
| @@ -129,8 +127,7 @@ void operator>>(const YAML::Node& node, T& i) | |||
| typedef const YAML::Node* yaml_node_t; | |||
|
|
|||
| // Helper function to find a value (yaml-cpp 0.3) | |||
- using utility function parse() - removing yaml-cpp 0.3 support
rhaschke
force-pushed
the
msa-yaml-parsing
branch
from
42691db
to
3caf297
Compare
sjahr
pushed a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
Signed-off-by: Gaël Écorchard <gael.ecorchard@cvut.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While tracking down a bug in yaml parsing, which finally turned out to be a bug in yamp-cpp itself (jbeder/yaml-cpp#568), I cleaned the code a little bit.