allow execution of empty trajectories #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful because the plan_execution allows arbitrary callbacks to run after successful execution of individual plan_components_. So although the *trajectory* might be empty we miss to run the associated callbacks if we just skip the component/trajectory altogether. This mechanism is very convenient for modular plans where some components only invoke side effects.
rhaschke
approved these changes
Jun 5, 2018
rhaschke
pushed a commit
that referenced
this pull request
Jun 5, 2018
This is useful because the plan_execution allows arbitrary callbacks to run after successful execution of individual plan_components_. So although the *trajectory* might be empty we miss to run the associated callbacks if we just skip the component/trajectory altogether. This mechanism is very convenient for modular plans where some components only invoke side effects.
dg-shadow
pushed a commit
to shadow-robot/moveit
that referenced
this pull request
Jul 30, 2018
This is useful because the plan_execution allows arbitrary callbacks to run after successful execution of individual plan_components_. So although the *trajectory* might be empty we miss to run the associated callbacks if we just skip the component/trajectory altogether. This mechanism is very convenient for modular plans where some components only invoke side effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful because the plan_execution allows arbitrary callbacks
to run after successful execution of individual plan_components_.
So although the trajectory might be empty, we miss to run the
associated callbacks if we just skip the component/trajectory altogether.
This mechanism is very convenient for modular plans where some components
only invoke side effects.
@rhaschke