towards python3 support #1054
Merged
towards python3 support #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
VERSION_GREATER_EQUAL was introduced in cmake 3.7. The minimum required version here is 2.8.12. That is why the CI fails. You can use |
|
If you write out the open issues and how to compile with python3, maybe someone could pursue this on WMD? |
v4hn
force-pushed
the
pr-kinetic-python3
branch
from
60f7b08
to
6b51d72
Compare
|
Thanks for looking up the minimum version @timonegk . I changed it as you suggested. @felixvd That was the plan, feel free to look into it. :) |
mlautman
approved these changes
Sep 13, 2018
| @@ -10,6 +12,11 @@ | |||
| import argparse | |||
| from moveit_commander import MoveGroupCommandInterpreter, MoveGroupInfoLevel, roscpp_initialize, roscpp_shutdown | |||
|
|
|||
| # compatibility with python3 | |||
| # python2's input function is dangerous anyway | |||
| if hasattr(__builtins__, 'raw_input'): | |||
There was a problem hiding this comment.
__builtin__
https://stackoverflow.com/a/11181616
There is no need to hardcode python2 in here anymore. Instead rely on whatever ROS was configured to use. https://www.boost.org/doc/libs/1_68_0/libs/python/doc/html/rn.html#rn.version_1_67 Additionally current releases of boost use python27/python36 for the component.
Python3 requires these to be explicit.
v4hn
force-pushed
the
pr-kinetic-python3
branch
from
6b51d72
to
8e0e087
Compare
|
Sorry for the delay.
I addressed your comment, @mlautman
|
v4hn
added a commit
that referenced
this pull request
Sep 23, 2018
* detect correct version of python/boost-python There is no need to hardcode python2 in here anymore. Instead rely on whatever ROS was configured to use. https://www.boost.org/doc/libs/1_68_0/libs/python/doc/html/rn.html#rn.version_1_67 Additionally current releases of boost use python27/python36 for the component. * moveitjoy: fix single print statement * moveit_commander: fix print function usage * moveit_commander: fix many implicit local includes Python3 requires these to be explicit. * moveit_commander: python3-compatible cli input
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Sep 27, 2018
This reverts commit 8c62cf2. Breaks Python2 support
7 tasks
rhaschke
pushed a commit
that referenced
this pull request
Oct 21, 2018
rhaschke
pushed a commit
to ubi-agni/moveit
that referenced
this pull request
Oct 21, 2018
pull bot
pushed a commit
to shadow-robot/moveit
that referenced
this pull request
Sep 3, 2020
* detect correct version of python/boost-python There is no need to hardcode python2 in here anymore. Instead rely on whatever ROS was configured to use. https://www.boost.org/doc/libs/1_68_0/libs/python/doc/html/rn.html#rn.version_1_67 Additionally current releases of boost use python27/python36 for the component. * moveitjoy: fix single print statement * moveit_commander: fix print function usage * moveit_commander: fix many implicit local includes Python3 requires these to be explicit. * moveit_commander: python3-compatible cli input
sjahr
pushed a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of (hopefully backward-compatible) patches enables us to build MoveIt with python 3 if the underlying ROS distribution was compiled with python 3 too.
It also fixes a number of common python 2/3 compatibility issues.
Additionally it supports the new boost-style for the python component.
With this I can successfully build MoveIt in python3 and run the moveit_commander_cmdline.py to get a prompt.
There is still open issues (if you try to "use" a group, the shell dies...), but I will leave those to someone else.