-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update include statements to use new pluginlib and class_loader headers #827
update include statements to use new pluginlib and class_loader headers #827
Conversation
…b and class_loader headers
…b and class_loader headers
…nd class_loader headers
… and class_loader headers
…new pluginlib and class_loader headers
…and class_loader headers
…and class_loader headers
…nlib and class_loader headers
…lib and class_loader headers
… pluginlib and class_loader headers
…d class_loader headers
…b and class_loader headers
…luginlib and class_loader headers
…ew pluginlib and class_loader headers
…ib and class_loader headers
…b and class_loader headers
CI tells us that this is not yet rolled out in indigo and kinetic. So we should not merge it yet. |
These changes have been rolled out in indigo and kinetic during the last sync. CI fails fails because the docker images it uses have not been rebuilt since the last sync. Running an |
I retriggered Travis. The docker containers should have been rebuild 5 days ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will rebase and resolve conflicts and then squash-merge.
Thanks @rhaschke. |
@mikaelarguedas I know about the github merge features. However, in the meantime this PR had a minor merge conflict with the main branch. In this case, you can only go for a fixing merge... |
👍 |
In |
This change should not impact downstream packages as both versions of the headers are installed and released. Moveit 0.9.12 builds successfully on the buildfarm on both Kinetic and Lunar. Can you provide more details about the build failure you are referring to ? |
Our CI server as well as ROS build farm can perfectly build this. Maybe you need to update your pluginlib installation? |
@knorth55 This commit only adjusts to the new headers, the old headers are still there. |
@mikaelarguedas I actually hit problems with the header changes though: pal-robotics maintains their own mirror of packages for TIAGo with a more cautious policy than OSRF. |
If you rely on a different package repo, you shouldn't update the MoveIt package as well... |
Oh, sorry. I misunderstood the problem. |
Good to know, has the problem been reported to them ? If so can you please provide a link here ?
Maybe there's history I'm missing here, but I don't recall suggesting that. I think the part that was missing in this PR is a version constraint on the pluginlib dependency in the |
I realized in our jenkins, and the docker image in the jenkins was not updated. |
Disclaimer: This in an automated PR, if it is not relevant on this branch, apologies for the inconveniance, feel free close it.
pluginlib
andclass_loader
headers have been refactored and renamed. The previous headers.h
have been deprecated in favor of their.hpp
equivalent. The new headers are available on all active ROS distributions and the deprecated ones will be removed in a future version of ROS (likely ROS-N).This PR migrates the include statements to use the non-deprecated ones and should compile for any active ROS distribution starting with Indigo
The migration was done by running the scripts pluginlib_headers_migration.py and class_loader_headers_update.py on this repository.
Note: this will not work for Jade