-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port rdf_loader to ROS2 #104
Conversation
moveit_ros/planning/rdf_loader/include/moveit/rdf_loader/rdf_loader.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good so far. +1 from me after you fixed up the remaining changes
0739631
to
83c9ba4
Compare
|
||
if (!nh.searchParam(robot_description, robot_description_) || !nh.getParam(robot_description_, content)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I'm happy with the new implementation, has_parameter()
+ get_parameter
seems like an overhead to me. Also, we need to discuss how searchParam()
should be implemented. @mkhansen-intel do you have any suggestions for this part?
83c9ba4
to
478ac98
Compare
180c194
to
2073c64
Compare
Description
This is a continuation of PR#76
The addressed review was added to the master branch see but because I'm not able to cherry-pick the changes for the specific files of rdf_loader, I just applied the changes to the rdf_loader and committed them