-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix moveit_configs_utils parameter ordering #1315
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1315 +/- ##
==========================================
+ Coverage 61.56% 61.58% +0.02%
==========================================
Files 274 274
Lines 24966 24966
==========================================
+ Hits 15369 15373 +4
+ Misses 9597 9593 -4
Continue to review full report at Codecov.
|
moveit_config.to_dict(), | ||
move_group_configuration, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the reordering necessary? Is it because we have the parameter in both variables and the second one will be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I want that parameter to be set to true.
2d382b9
to
9dc4d44
Compare
9dc4d44
to
6b12e23
Compare
Because #1265 added a value for
publish_robot_description_semantic
, the value specified in the move_group launch is overwritten.Either we should fix this by changing the order the parameters are loaded (as in this PR) OR the default value of
publish_robot_description_semantic
should be true.Checklist