Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moveit_configs_utils parameter ordering #1315

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Jun 3, 2022

Because #1265 added a value for publish_robot_description_semantic, the value specified in the move_group launch is overwritten.

Either we should fix this by changing the order the parameters are loaded (as in this PR) OR the default value of publish_robot_description_semantic should be true.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #1315 (9dc4d44) into main (541baa8) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 9dc4d44 differs from pull request most recent head 6b12e23. Consider uploading reports for the commit 6b12e23 to get more accurate results

@@            Coverage Diff             @@
##             main    #1315      +/-   ##
==========================================
+ Coverage   61.56%   61.58%   +0.02%     
==========================================
  Files         274      274              
  Lines       24966    24966              
==========================================
+ Hits        15369    15373       +4     
+ Misses       9597     9593       -4     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.73% <0.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 541baa8...6b12e23. Read the comment docs.

moveit_config.to_dict(),
move_group_configuration,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the reordering necessary? Is it because we have the parameter in both variables and the second one will be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I want that parameter to be set to true.

@DLu DLu mentioned this pull request Jun 10, 2022
6 tasks
@DLu DLu force-pushed the fix_parameter_ordering branch 2 times, most recently from 2d382b9 to 9dc4d44 Compare June 13, 2022 14:35
@DLu DLu requested a review from JafarAbdi June 13, 2022 16:37
@JafarAbdi JafarAbdi merged commit 31d3566 into moveit:main Jun 13, 2022
@DLu DLu deleted the fix_parameter_ordering branch June 13, 2022 20:11
peterdavidfagan pushed a commit to peterdavidfagan/moveit2 that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants