Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraint samplers seed #1411

Merged
merged 14 commits into from
Jul 28, 2022

Conversation

henrygerardmoore
Copy link
Contributor

Description

Closes #1401.
Changes seed from ROS parameter to optional uint constructor input and re-enables JointConstraintsSamplerSeeded and IKConstraintsSamplerSeeded tests.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #1411 (ec494bf) into main (70d99c3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1411      +/-   ##
==========================================
+ Coverage   50.89%   50.90%   +0.01%     
==========================================
  Files         381      381              
  Lines       31784    31786       +2     
==========================================
+ Hits        16174    16177       +3     
+ Misses      15610    15609       -1     
Impacted Files Coverage Δ
...raint_samplers/src/default_constraint_samplers.cpp 71.83% <ø> (-0.15%) ⬇️
.../constraint_samplers/default_constraint_samplers.h 80.65% <100.00%> (+2.87%) ⬆️
moveit_core/robot_state/src/robot_state.cpp 47.44% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d99c3...ec494bf. Read the comment docs.

@henrygerardmoore henrygerardmoore changed the title WIP: Constraint samplers seed Constraint samplers seed Jun 30, 2022
@henrygerardmoore
Copy link
Contributor Author

henrygerardmoore commented Jun 30, 2022

c01a6d7 fails CI due to #1334.

@henrygerardmoore henrygerardmoore marked this pull request as ready for review June 30, 2022 19:06
Copy link
Contributor

@jliukkonen jliukkonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things. Looks like a useful improvement to me otherwise.

Copy link
Contributor

@jliukkonen jliukkonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@henrygerardmoore henrygerardmoore self-assigned this Jul 22, 2022
@henrygerardmoore
Copy link
Contributor Author

CI fails from #1334

@vatanaksoytezer vatanaksoytezer merged commit 03f225a into moveit:main Jul 28, 2022
peterdavidfagan pushed a commit to peterdavidfagan/moveit2 that referenced this pull request Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constraint samplers with seed
4 participants