-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constraint samplers seed #1411
Constraint samplers seed #1411
Conversation
...it_core/constraint_samplers/include/moveit/constraint_samplers/default_constraint_samplers.h
Outdated
Show resolved
Hide resolved
moveit_core/constraint_samplers/src/default_constraint_samplers.cpp
Outdated
Show resolved
Hide resolved
moveit_core/constraint_samplers/test/test_constraint_samplers.cpp
Outdated
Show resolved
Hide resolved
moveit_core/constraint_samplers/test/test_constraint_samplers.cpp
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1411 +/- ##
==========================================
+ Coverage 50.89% 50.90% +0.01%
==========================================
Files 381 381
Lines 31784 31786 +2
==========================================
+ Hits 16174 16177 +3
+ Misses 15610 15609 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small things. Looks like a useful improvement to me otherwise.
...it_core/constraint_samplers/include/moveit/constraint_samplers/default_constraint_samplers.h
Outdated
Show resolved
Hide resolved
...it_core/constraint_samplers/include/moveit/constraint_samplers/default_constraint_samplers.h
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
CI fails from #1334 |
Description
Closes #1401.
Changes seed from ROS parameter to optional uint constructor input and re-enables
JointConstraintsSamplerSeeded
andIKConstraintsSamplerSeeded
tests.Checklist