Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port planning components tools #149

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

JafarAbdi
Copy link
Member

Description

This's a partial port the other executable need porting planning scene monitor first

For the multi-threading section, I used the method here

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @JafarAbdi do you consider this done or do we need to add/test something?
Also, please rebase and update commit descriptions before merge

@JafarAbdi
Copy link
Member Author

Looks good to me. @JafarAbdi do you consider this done or do we need to add/test something?

Few minutes and I'll force push the latest changes

@JafarAbdi
Copy link
Member Author

@henningkayser Done!

@henningkayser henningkayser merged commit c302b18 into moveit:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants