Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated declaration usage #1598

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Conversation

Abishalini
Copy link
Contributor

Description

The new rolling update has deprecated the usage of function parameter of type rmw_qos_profile_t when calling create_client function.
Related issue - ros2/rclcpp#1964
CI fails due to this warning which GCC will promote to an error and fails the build.

rclcpp::CallbackGroup::SharedPtr = std::shared_ptr<rclcpp::CallbackGroup>]’ is deprecated: use rclcpp::QoS instead of rmw_qos_profile_t [-Werror=deprecated-declarations]
    164 |     query_service_ = node_->create_client<moveit_msgs::srv::QueryPlannerInterfaces>(
        |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
    165 |         rclcpp::names::append(opt_.move_group_namespace_, move_group::QUERY_PLANNERS_SERVICE_NAME),
        |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    166 |         rmw_qos_profile_services_default, callback_group_);
        |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~   

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Here's a fix for it

@Abishalini Abishalini changed the title Fix type Fix deprecated declaration usage Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 51.08% // Head: 51.11% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (b6a5530) compared to base (5c3f98e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1598      +/-   ##
==========================================
+ Coverage   51.08%   51.11%   +0.03%     
==========================================
  Files         381      381              
  Lines       31790    31790              
==========================================
+ Hits        16238    16246       +8     
+ Misses      15552    15544       -8     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.29% <0.00%> (-0.43%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 47.83% <0.00%> (-0.07%) ⬇️
moveit_ros/moveit_servo/src/pose_tracking.cpp 77.26% <0.00%> (+0.48%) ⬆️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 76.43% <0.00%> (+1.08%) ⬆️
moveit_ros/moveit_servo/src/servo_calcs.cpp 67.95% <0.00%> (+1.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vatanaksoytezer
Copy link
Contributor

We need to remove humble CI from main, since this would break humble.

@tylerjw
Copy link
Member

tylerjw commented Oct 4, 2022

We need to remove humble CI from main, since this would break humble.

Hopefully we can find a way to make this change in a way where it builds for both humble and rolling.

Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this important PR that unblocks CI!

@AndyZe AndyZe merged commit 24006be into moveit:main Oct 10, 2022
@Abishalini Abishalini deleted the fix_qos_warning branch October 10, 2022 14:42
@felixf4xu
Copy link

change warning level is not the correct way to go, fix the code by using rclcpp::SystemDefaultsQoS()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants