-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated declaration usage #1598
Conversation
Codecov ReportBase: 51.08% // Head: 51.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1598 +/- ##
==========================================
+ Coverage 51.08% 51.11% +0.03%
==========================================
Files 381 381
Lines 31790 31790
==========================================
+ Hits 16238 16246 +8
+ Misses 15552 15544 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
We need to remove humble CI from main, since this would break humble. |
Hopefully we can find a way to make this change in a way where it builds for both humble and rolling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this important PR that unblocks CI!
change warning level is not the correct way to go, fix the code by using |
Description
The new rolling update has deprecated the usage of function parameter of type
rmw_qos_profile_t
when callingcreate_client
function.Related issue - ros2/rclcpp#1964
CI fails due to this warning which GCC will promote to an error and fails the build.
Checklist
Here's a fix for it