Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added brace intialization in move_it/collision_detection #1615

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

abhijelly
Copy link
Contributor

Description

Please explain the changes you made, including a reference to the related issue if applicable

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@abhijelly abhijelly changed the title Added brace intialization in move_it/collision_detection #1609 Added brace intialization in move_it/collision_detection Oct 17, 2022
Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough, thank you!

@tylerjw tylerjw force-pushed the add-brace-initialization-fix branch from b2ce0aa to 9a0fb5c Compare October 17, 2022 21:04
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 51.10% // Head: 51.07% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (9a0fb5c) compared to base (cc63903).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1615      +/-   ##
==========================================
- Coverage   51.10%   51.07%   -0.02%     
==========================================
  Files         381      381              
  Lines       31738    31738              
==========================================
- Hits        16215    16206       -9     
- Misses      15523    15532       +9     
Impacted Files Coverage Δ
..._core/collision_detection/src/collision_common.cpp 50.00% <ø> (ø)
moveit_ros/moveit_servo/src/servo_calcs.cpp 66.45% <0.00%> (-1.49%) ⬇️
moveit_ros/moveit_servo/src/pose_tracking.cpp 76.78% <0.00%> (-0.47%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 47.91% <0.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tylerjw tylerjw merged commit f1d0ab5 into moveit:main Oct 17, 2022
@tylerjw tylerjw added the backport-humble Mergify label that triggers a PR backport to Humble label Oct 28, 2022
mergify bot pushed a commit that referenced this pull request Oct 28, 2022
(cherry picked from commit f1d0ab5)
tylerjw pushed a commit that referenced this pull request Oct 28, 2022
(cherry picked from commit f1d0ab5)

Co-authored-by: Abhijeet Das Gupta <75399048+abhijelly@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants