Use a stronger source of randomness #1721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rsl::rng()
seeds a Mersenne twister to the full extent allowed by the<random>
API so that we can ensure we're getting the highest quality randomness possible. Using this global random number generator also lets us remove a few member variables that existed for this same purpose.std::random_shuffle
has been deprecated and removed from the standard so I also replaced the remaining uses of that function withstd::shuffle
.Checklist