Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MOVEIT_LIB_NAME #1751

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Remove MOVEIT_LIB_NAME #1751

merged 1 commit into from
Nov 22, 2022

Conversation

ChrisThrasher
Copy link
Contributor

Description

Closes #1720

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Base: 50.94% // Head: 50.94% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (ab72138) compared to base (04a449f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1751      +/-   ##
==========================================
+ Coverage   50.94%   50.94%   +0.01%     
==========================================
  Files         378      378              
  Lines       31659    31659              
==========================================
+ Hits        16125    16126       +1     
+ Misses      15534    15533       -1     
Impacted Files Coverage Δ
moveit_core/robot_state/src/robot_state.cpp 47.91% <0.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tylerjw tylerjw self-assigned this Nov 19, 2022
Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice cleanup, thank you.

@ChrisThrasher
Copy link
Contributor Author

ChrisThrasher commented Nov 21, 2022

Do I need to rebase on main before this can be merged? I'm not sure if that's a requirement or not.

EDIT: Yes, it is a requirement.

It's more readable and searchable if we just spell out the target
name.
@tylerjw tylerjw merged commit acc64da into moveit:main Nov 22, 2022
@ChrisThrasher ChrisThrasher deleted the moveit_lib_name branch November 22, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace MOVEIT_LIB_NAME with target names
3 participants